Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

cmd: Move metrics-docs out of tetra and refactor it #2611

Merged
merged 2 commits into from
Jun 27, 2024
Merged

cmd: Move metrics-docs out of tetra and refactor it #2611

merged 2 commits into from
Jun 27, 2024

Conversation

lambdanis
Copy link
Contributor

@lambdanis lambdanis commented Jun 27, 2024 •
edited
Loading

See commits for details

metrics-docs command is removed from tetra CLI. This reduces the size of tetra binary. Metrics docs are now generated with a separate tetragon-metrics-docs binary.

lambdanis added 2 commits June 27, 2024 13:20
@lambdanis
cmd: Move metrics-docs out of tetra
5a66508 
The command generating metrics reference starts a metrics server and
initializes all the metrics. This means it needs to import a large chunk of
Tetragon code (every package that defines metrics). Before, the command was
included in tetra CLI. However, the large import graph is problematic for
tetra, so let's move metrics docs generation into a separate command.

Signed-off-by: Anna Kapuscinska <anna@isovalent.com>
@lambdanis
cmd: Refactor tetragon-metrics-docs command
17fe423 
Targets and InitMetrics function are now passed as arguments to the New
function. This is done so that the New function can be reused to generate
different references (e.g. for different metrics groups).

Signed-off-by: Anna Kapuscinska <anna@isovalent.com>
@lambdanis lambdanis added the release-note/misc This PR makes changes that have no direct user impact. label Jun 27, 2024
@lambdanis lambdanis requested a review from a team as a code owner June 27, 2024 12:31
@lambdanis lambdanis requested a review from tixxdz June 27, 2024 12:31
@lambdanis lambdanis merged commit 0d85b38 into cilium:main Jun 27, 2024
39 checks passed
@lambdanis lambdanis added release-note/minor This PR introduces a minor user-visible change and removed release-note/misc This PR makes changes that have no direct user impact. labels Jun 27, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@michi-covalent michi-covalent michi-covalent approved these changes

@tixxdz tixxdz Awaiting requested review from tixxdz tixxdz is a code owner automatically assigned from cilium/tetragon

Assignees
No one assigned
Labels
release-note/minor This PR introduces a minor user-visible change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lambdanis @michi-covalent