tetragon: clone namespace improvements #2695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
tixxdz
commented
Jul 18, 2024
tixxdz
commented
Store the thread leader namespaces during fork so we can check later if they changed, as right now they are only stored late during execv which will point to a new exec_id entry anyway. Right now during fork they are zeroed in the execve_map which make it unreliable to detect if they changed between the fork and the final execve, they will always be reported as if they changed which could be a false positive report. While we are it improve how we fetch and store capabilities. Signed-off-by: Djalal Harouni <tixxdz@gmail.com>
Signed-off-by: Djalal Harouni <tixxdz@gmail.com>
tixxdz
added
the
release-note/minor
|
CI failure seems unrelated |
tpapagian
approved these changes
Jul 19, 2024
Comment on lines
-69
to
-71
| curr->caps.permitted = caps.permitted; | ||
| curr->caps.effective = caps.effective; | ||
| curr->caps.inheritable = caps.inheritable; |
There was a problem hiding this comment.
Unrelated to that PR, but these assignments seems to be redundant as we did get_current_subj_caps? And this is the reason that you removed those now, right?
There was a problem hiding this comment.
This just minor optimization, since old code was reading in new var caps then copying back to curr->caps.$field, see next line in the patch, now we read directly into curr->caps , so just saved some cycles.
|
Thank you @tpapagian |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.