Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

tetra: fix --policy-names to apply all event types #3044

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

justin0u0
Copy link
Contributor

Description

In #1867, the --policy-names flag was added to filter events based on the tracing policy. However, the filter was only appled to kprobe events.

This patch extends the filter to support all events types: kprobe, tracepoint, uprobe and lsm.

@justin0u0 justin0u0 requested a review from a team as a code owner October 25, 2024 07:44
@justin0u0 justin0u0 requested a review from jrfastab October 25, 2024 07:44
Copy link
Contributor

@kkourt kkourt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Other than a minor comment, this LGTM!

In cilium#1867, the `--policy-names` flag was added to filter events
based on the tracing policy. However, the filter was only appled
to `kprobe` events.

This patch extends the filter to support all events types:
`kprobe`, `tracepoint`, `uprobe` and `lsm`.

Signed-off-by: Justin Chen <mail@justin0u0.com>
@justin0u0 justin0u0 force-pushed the fix/tetra-filter-policy-names branch from e84d039 to 547ccdd Compare October 25, 2024 09:05
@mtardy mtardy added the release-note/minor This PR introduces a minor user-visible change label Oct 25, 2024
Copy link
Contributor

@kkourt kkourt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@kkourt kkourt merged commit ba06bb9 into cilium:main Oct 28, 2024
39 of 40 checks passed
@justin0u0 justin0u0 deleted the fix/tetra-filter-policy-names branch October 29, 2024 02:05
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
release-note/minor This PR introduces a minor user-visible change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants