helm: Add part-of and component labels #3052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lambdanis
added
release-note/minor
lambdanis
force-pushed
the
pr/lambdanis/helm-labels
branch
from
63c2d02 to
7178f9f
Compare
lambdanis
force-pushed
the
pr/lambdanis/helm-labels
branch
from
7178f9f to
bedabbb
Compare
There are no functional changes in this commit, only refactoring. Signed-off-by: Anna Kapuscinska <anna@isovalent.com>
They're recommended by Kubernetes, so let's add them. See: https://kubernetes.io/docs/concepts/overview/working-with-objects/common-labels/ Signed-off-by: Anna Kapuscinska <anna@isovalent.com>
lambdanis
force-pushed
the
pr/lambdanis/helm-labels
branch
from
bedabbb to
fe56a72
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also refactor the labels templates (deduplicate).