tetragon: Move procevents.GetRunningProcs call from base sensor load #3097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olsajiri
added
the
release-note/minor
olsajiri
force-pushed
the
pr/olsajiri/getprocs
branch
4 times, most recently
from
24984fc to
3f0107e
Compare
We need to call procevents.GetRunningProcs after server is started observer listeners are configured. Currently it's called within base sensor load, but it's now loaded before server is started, so we don't get any initial exec events. Fixes: a5d7f0e ("tetragon: Load initial sensor via sensor manager") Signed-off-by: Jiri Olsa <jolsa@kernel.org>
olsajiri
force-pushed
the
pr/olsajiri/getprocs
branch
from
3f0107e to
3d3213b
Compare
Execute tetragon through main and make sure we get exec events generated. Signed-off-by: Jiri Olsa <jolsa@kernel.org>
olsajiri
force-pushed
the
pr/olsajiri/getprocs
branch
from
3d3213b to
75167f5
Compare
tpapagian
reviewed
Nov 11, 2024
| tus.LoadSensor(t, base.GetInitialSensor()) | ||
| tus.LoadInitialSensor(t) | ||
|
|
||
| if err := procevents.GetRunningProcs(); err != nil { |
There was a problem hiding this comment.
Do we need that here? It seems that tus.LoadInitialSensor(t) also calls procevents.GetRunningProcs().
There was a problem hiding this comment.
ugh, leftover, will remove, thanks
tpapagian
approved these changes
Nov 11, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to call procevents.GetRunningProcs after server is started observer listeners are configured.
Currently it's called within base sensor load, but it's now loaded before server is started, so we don't get any initial exec events.