tetragon: Allow multiple symbol instances in kprobe spec #3121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for tetragon ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
olsajiri
force-pushed
the
pr/olsajiri/fixes
branch
from
d2c2461 to
213909d
Compare
olsajiri
added
the
release-note/minor
olsajiri
force-pushed
the
pr/olsajiri/fixes
branch
from
213909d to
9eb2768
Compare
kkourt
approved these changes
Nov 19, 2024
Kornilios reported issue when having same symbol defined inside tracing policy. We can address that in NON kprobe-multi mode and add instance sufix to the program name and hence bpffs program directory, and that separation resolves the issue. But this won't work for kprobe-multi, because we have just single program that can't be attached twice on single function. So allowing this only for non kprobe-multi mode. Signed-off-by: Jiri Olsa <jolsa@kernel.org>
olsajiri
force-pushed
the
pr/olsajiri/fixes
branch
from
9eb2768 to
8c6f9e9
Compare
Make sure we fail when having multiple symbol instances in kprobe multi mode and that we work properly in NON kprobe multi mode. Signed-off-by: Jiri Olsa <jolsa@kernel.org>
olsajiri
force-pushed
the
pr/olsajiri/fixes
branch
from
8c6f9e9 to
696cba8
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it's ok for non kprobe-multi specs and we retrn error in kprobe-multi mode
Fixes: #2947