exec: fix tracking of matchBinary children #3186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkourt
added
kind/bug
kkourt
added
the
release-note/bug
tixxdz
approved these changes
Dec 5, 2024
olsajiri
reviewed
Dec 5, 2024
If we executed a binary that directly executed in another binary, the ->mb_bitset field was zeroed out and the information was lost, which meant that the matching would not work as expected. Fix this by i) not zeroing out the ->mb_bitset field and, also, or it with the parent. Add a test. Fixes: e73718c ("exec: track matchbinary children") Signed-off-by: Kornilios Kourtis <kornilios@isovalent.com>
kkourt
force-pushed
the
pr/kkourt/matchibnaries-fix
branch
from
42837d5 to
41c7a74
Compare
olsajiri
approved these changes
Dec 9, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.