Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add --local-checkout option #119

Merged
merged 3 commits into from
Apr 21, 2022
Merged

Add --local-checkout option #119

merged 3 commits into from
Apr 21, 2022

Conversation

LegenJCdary
Copy link
Collaborator

fixing issue #114

@LegenJCdary LegenJCdary marked this pull request as draft April 20, 2022 14:52
@LegenJCdary LegenJCdary force-pushed the add_local_checkout branch 3 times, most recently from 3c3670e to a119289 Compare April 20, 2022 15:48
@LegenJCdary LegenJCdary marked this pull request as ready for review April 20, 2022 15:51
@LegenJCdary LegenJCdary requested a review from cinek810 April 20, 2022 15:51
@LegenJCdary LegenJCdary marked this pull request as draft April 20, 2022 22:09
@LegenJCdary LegenJCdary added the enhancement New feature or request label Apr 21, 2022
@LegenJCdary LegenJCdary force-pushed the add_local_checkout branch 3 times, most recently from ede13df to a4c5f0c Compare April 21, 2022 08:39
@LegenJCdary LegenJCdary marked this pull request as ready for review April 21, 2022 08:40
@LegenJCdary LegenJCdary force-pushed the add_local_checkout branch 3 times, most recently from d43194c to 87ecc57 Compare April 21, 2022 09:05
Add functions validate_checkout and validate_local_checkout
Add allow_user_checkout field in infra cfg
@LegenJCdary LegenJCdary force-pushed the add_local_checkout branch 2 times, most recently from 0612054 to c9ec405 Compare April 21, 2022 11:09
Copy link
Owner

@cinek810 cinek810 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's good, I'd just change test file name "with_local_checkout" doesn't match option name now

@@ -35,6 +35,9 @@ jobs:
command: |
./tests/01-test_argument_parsing.sh
./tests/02-checkrun.sh
mkdir -p /etc/alt-workdir
./tests/02a-checkrun_with_local_checkout.sh
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

_self_setup?

Add new test file and adjust circleci
Add functions to testing lib: find_latest_sequence, check_file_startingwith_in_dir
@LegenJCdary LegenJCdary force-pushed the add_local_checkout branch 2 times, most recently from 83938e3 to b204f81 Compare April 21, 2022 12:06
@LegenJCdary LegenJCdary merged commit 4dd7c9b into main Apr 21, 2022
@LegenJCdary LegenJCdary deleted the add_local_checkout branch April 21, 2022 12:12
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants