Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

core functions draft #12

Closed
wants to merge 1 commit into from
Closed

core functions draft #12

wants to merge 1 commit into from

Conversation

LegenJCdary
Copy link
Collaborator

No description provided.

@LegenJCdary LegenJCdary requested a review from cinek810 January 31, 2022 09:55
@cinek810
Copy link
Owner

no need to lock work_dir - we just need to fix todo to lock parent dir when workdir created
for inventory locking - that's fine
for hooks - we should skip it for now, the only hook we need to run in 1st working version is a setup_hook

cinek810
cinek810 reviewed Jan 31, 2022
View reviewed changes
Copy link
Owner

@cinek810 cinek810 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check how I did it on #13 , I think that one covers what we need to work on that today.

@LegenJCdary LegenJCdary closed this Feb 1, 2022
@LegenJCdary LegenJCdary deleted the add_core_functions branch February 1, 2022 08:29
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@cinek810 cinek810 cinek810 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LegenJCdary @cinek810