bugfix setup hook still running when --self-setup on #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LegenJCdary
force-pushed
the
bugfix_setuphook_always_running
branch
2 times, most recently
from
08710ef to
0144e15
Compare
LegenJCdary
force-pushed
the
bugfix_setuphook_always_running
branch
from
0144e15 to
2c63112
Compare
cinek810
requested changes
Jul 5, 2022
.circleci/config.yml
Outdated
| @@ -36,6 +36,7 @@ jobs: | |||
| ./tests/01-test_argument_parsing.sh | |||
| ./tests/02-checkrun.sh | |||
| mkdir -p /etc/alt-workdir | |||
| pushd /etc/alt-workdir && /etc/ansible-deployer/hooks/setup_work_dir.sh && popd | |||
There was a problem hiding this comment.
should be multiline - if we fail to setup_work_dir we still want to popd ?
| @@ -5,12 +5,10 @@ source ./tests/testing_lib.sh | |||
|
|
|||
| # Check if cwd is correctly switched when using --self-setup option | |||
| check_message_in_output "ansible-deployer run -t task_exec_bin_true -s testing -i testInfra -d --self-setup /etc/alt-workdir" "\[DEBUG\]: Successfully created workdir: /tmp/" | |||
| check_message_in_output "ansible-deployer run -t task_exec_bin_true -s testing -i testInfra -d --self-setup /etc/alt-workdir" "\[INFO\]: Setup completed in /etc/alt-workdir" | |||
There was a problem hiding this comment.
maybe we should check if it's not in output? We had a bug so we need a regression test against the fix
LegenJCdary
force-pushed
the
bugfix_setuphook_always_running
branch
from
2c63112 to
e5879c4
Compare
LegenJCdary
force-pushed
the
bugfix_setuphook_always_running
branch
2 times, most recently
from
29fd1cb to
b51413c
Compare
cinek810
approved these changes
Aug 29, 2022
bugfix 4c75723 adjust tests and circle cfg
LegenJCdary
force-pushed
the
bugfix_setuphook_always_running
branch
from
b51413c to
248ae3f
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bugfix 4c75723