Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add support for skip_tags #166

Merged
merged 2 commits into from
Feb 17, 2023
Merged

Add support for skip_tags #166

merged 2 commits into from
Feb 17, 2023

Conversation

cinek810
Copy link
Owner

@cinek810 cinek810 commented Feb 1, 2023

No description provided.

@cinek810 cinek810 force-pushed the add_skip_tags branch 3 times, most recently from fc92a7d to c3f6120 Compare February 1, 2023 12:47
@cinek810 cinek810 requested a review from LegenJCdary February 1, 2023 13:14
Copy link
Collaborator

@LegenJCdary LegenJCdary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit-picky changes

@@ -189,12 +189,17 @@ def get_tags_for_task(config: dict, options: dict):
if options["dry_mode"]:
tags.append("ansible_deployer_dry_mode")

return tags
skip_tags = []
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be defined at the beginning of function.

fi
}


Copy link
Collaborator

@LegenJCdary LegenJCdary Feb 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove

@@ -21,12 +21,12 @@ check_run_fail() {
$CMD
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

squash

@cinek810 cinek810 merged commit 3c6a929 into main Feb 17, 2023
@LegenJCdary LegenJCdary deleted the add_skip_tags branch February 17, 2023 08:46
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants