Adding tests to 02-checkrun.sh #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cinek810
requested changes
Feb 2, 2022
LegenJCdary
force-pushed
the
checkrun_tests
branch
13 times, most recently
from
b088373 to
6218d0d
Compare
LegenJCdary
force-pushed
the
checkrun_tests
branch
2 times, most recently
from
f4f9f6a to
6bf8fd5
Compare
LegenJCdary
force-pushed
the
checkrun_tests
branch
6 times, most recently
from
4e6b00a to
6bdeb1c
Compare
cinek810
force-pushed
the
checkrun_tests
branch
from
6bdeb1c to
72091bd
Compare
cinek810
force-pushed
the
checkrun_tests
branch
from
a89aa42 to
f5f4148
Compare
cinek810
requested changes
Feb 4, 2022
| @@ -4,4 +4,6 @@ infrastructures: | |||
| - name: testing | |||
| inventory: ./test_infra1_inv.yaml | |||
| - name: prod | |||
| inventory: ./prod_infra1.inv.yaml | |||
| inventory: ./prod_infra1_inv.yaml | |||
| - name: locked | |||
| config = load_configuration() | ||
| validate_option_values_with_config(config, options) | ||
| validate_option_values_against_config(config, options, required_opts) |
There was a problem hiding this comment.
sounds good but it's nice to have separate commit for just name change to make the history easier to check. Maybe not so important on current stage.
ansible_deploy/command_line.py
Outdated
| @@ -129,6 +129,7 @@ def validate_options(options, subcommand): | |||
| required = ["infra", "stage"] | |||
| notsupported = ["task", "commit"] | |||
| elif subcommand == "list": | |||
| required = [] | |||
There was a problem hiding this comment.
isn't it redundant? required is defined before if
ansible_deploy/command_line.py
Outdated
| @@ -354,7 +354,7 @@ def run_task(config: dict, options: dict, inventory: str): | |||
| sys.exit(70) | |||
| else: | |||
| for playbook in playbooks: | |||
| command = ["ansible-playbook", "-l", options["infra"], "-i", inventory, playbook] | |||
| command = ["ansible-playbook", "-i", inventory, playbook] | |||
There was a problem hiding this comment.
It's good that it's a separate commit but this is rally a fix, so commit message should mention that
etc/lock_infra1_inv.yaml
Outdated
| @@ -0,0 +1,2 @@ | |||
| 420 | |||
| cinek | |||
There was a problem hiding this comment.
new line at the end of yaml? strange to call inventory "lock" :) If it's just for tests... I'd say add it to setup_hook so we can run tests locally without a file being copied prior running
etc/ansible-deploy.yaml
Outdated
| - name: parent_work_dir | ||
| value: "/tmp" | ||
|
|
||
| - name: parent_config_dir |
There was a problem hiding this comment.
this one has to be hardcoded - can't read config without that
cinek810
approved these changes
Feb 4, 2022
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.