Add --keep-locked option #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LegenJCdary
force-pushed
the
keep_locked_switch
branch
2 times, most recently
from
2d841e3 to
77703c8
Compare
cinek810
requested changes
Apr 7, 2022
| @@ -541,7 +544,11 @@ def run_playitem(config: dict, options: dict, inventory: str, lockpath: str): | |||
| logger.error("'%s' failed due to:", command) | |||
| for line in std_e.split(b"\n\n"): | |||
| logger.error(line.decode("utf-8")) | |||
| unlock_inventory(lockpath) | |||
There was a problem hiding this comment.
I feel that the whole try block should go to sparate function to reduc e number of branches?
There was a problem hiding this comment.
or just put this in unloc_inventory to avoid code duplication, just pass it a bool options["keep_locked"]
tests/pylintrc
Outdated
| @@ -518,7 +518,7 @@ max-attributes=7 | |||
| max-bool-expr=5 | |||
|
|
|||
| # Maximum number of branch for function / method body. | |||
| max-branches=16 | |||
There was a problem hiding this comment.
w can't continue increasing it, we need to work on that to decrase the branches
There was a problem hiding this comment.
Alright, I'll do that with #84
LegenJCdary
force-pushed
the
keep_locked_switch
branch
from
77703c8 to
a708115
Compare
LegenJCdary
force-pushed
the
keep_locked_switch
branch
2 times, most recently
from
ad47937 to
dd46453
Compare
cinek810
approved these changes
Apr 13, 2022
ansible_deployer/command_line.py
Outdated
| logger.critical(exc) | ||
| sys.exit(64) | ||
| else: | ||
| logger.debug("Requested infra %s:%s remains locked.", options["infra"], options["stage"]) |
There was a problem hiding this comment.
Personally, it will be easier (for me) to understand message refering to '--keep-locked' option
LegenJCdary
force-pushed
the
keep_locked_switch
branch
from
dd46453 to
1a27a0b
Compare
LegenJCdary
force-pushed
the
keep_locked_switch
branch
from
1a27a0b to
1bd83dc
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixing issue #87