Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Feature Request: PWA #17

Open
farribeiro opened this issue Jul 30, 2021 · 24 comments
Open

Feature Request: PWA #17

farribeiro opened this issue Jul 30, 2021 · 24 comments
Labels
type: feature New feature or request

Comments

@farribeiro
Copy link

farribeiro commented Jul 30, 2021

https://web.dev/progressive-web-apps/

@ajbura ajbura added the type: feature New feature or request label Aug 4, 2021
@vwkd
Copy link

vwkd commented Oct 7, 2021

I think this issue confuses PWA with just being responsive.

@frostedkitsune
Copy link

I think this issue confuses PWA with just being responsive.

I think so PWA and responsive design are two different things....btw, what is the progress on any of this topic?

@ajbura ajbura mentioned this issue Dec 1, 2021
@C0ffeeCode
Copy link
Contributor

This might be interesting regarding this issue:
https://developer.mozilla.org/en-US/docs/Web/API/Badging_API

@RihanArfan
Copy link

PWA will allow Cinny to be installable on desktop or mobile and make it feel like a native app. Other things can be done like full offline support so it loads fully from the cache.

This might help. https://create-react-app.dev/docs/making-a-progressive-web-app/

@reesericci
Copy link

I would like to see PWA support, as then I could use Cinny on my phone like a native app.

@Iruwen
Copy link

Iruwen commented Jul 12, 2022

I assume we need a PWA service worker to get true push notification support on mobile besides caching, so this would be a killer feature.

@C0ffeeCode
Copy link
Contributor

C0ffeeCode commented Jul 12, 2022

I had been working on implementing background notifications using service worker, but it requires changes to how Cinny saves the token since localstorage, where it lives today, is not available in serviceworkers, so it would have to be migrated to indexeddb.
If someone is interested to take it over:
https://github.com/c0ffeecode/cinny/tree/background-notifications

It takes advantage of push gateways and ntfy, so it can listen for notifications using WebSockets efficiently.

As for the Tauri build, it propably would be better implement background notifications in rust.

@genofire
Copy link

genofire commented Aug 4, 2022

@C0ffeeCode it sounds you do not use VAPID WebPush Notification for this insteat:
https://support.mozilla.org/en-US/kb/push-notifications-firefox

Like hydrogen-web it does: https://github.com/vector-im/hydrogen-web

@Iruwen
Copy link

Iruwen commented Aug 5, 2022

By its description it doesn't sound like there's an "instead" due to its severe limitations.

@rltas
Copy link

rltas commented Aug 31, 2022

Looks like it'll become much more useful "soon":
https://webkit.org/blog/12945/meet-web-push/
https://firt.dev/ios-15.4b#web-push-notifications-on-ios%EF%BC%8Dwith-a-catch

@genofire
Copy link

See also #867 for non web

greentore pushed a commit to greentore/greeny that referenced this issue Feb 13, 2023
Bumps [@tauri-apps/cli](https://github.com/tauri-apps/tauri) from 1.0.0-rc.11 to 1.0.0-rc.12.
- [Release notes](https://github.com/tauri-apps/tauri/releases)
- [Commits](tauri-apps/tauri@v1.0.0-rc.11...v1.0.0-rc.12)

---
updated-dependencies:
- dependency-name: "@tauri-apps/cli"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@RihanArfan
Copy link

Now that we're using Vite, we can use Vite PWA. https://vite-pwa-org.netlify.app/frameworks/react.html

@jasikpark
Copy link

jasikpark commented May 6, 2023

web notifs nearly work today on iOS Safari 16.4, except there seems to be a bug in the notif system, where it doesn't think it does have perms?

I have #1231 up to fix the rendering issue, though since there's not a service worker, that PR doesn't fix iOS notifications

@jasikpark
Copy link

@kfiven kfiven moved this to PWA and responsiveness in Public roadmap Jun 20, 2023
@NovaAndrom3da
Copy link

I would love to have proper iOS notification support, that seems to be the only thing I'm missing

@filipesmedeiros
Copy link

This is a low hanging fruit if we just want to enable installation, basically just add a web manifest, right?

@MulverineX
Copy link

Features like offline support & web push integration would be great, but yeah just getting the manifest and a dummy service worker in so installs are possible would be great. ( @filipesmedeiros simply adding the manifest isn't enough, browsers will refuse to install the PWA if there is no service worker present )

@filipesmedeiros
Copy link

@MulverineX that sounds right. Still easy just to enable installation, imo eheh

@RihanArfan
Copy link

Features like offline support & web push integration would be great, but yeah just getting the manifest and a dummy service worker in so installs are possible would be great. ( @filipesmedeiros simply adding the manifest isn't enough, browsers will refuse to install the PWA if there is no service worker present )

Now that we're using Vite, we can use Vite PWA. https://vite-pwa-org.netlify.app/frameworks/react.html

Vite PWA can take care of all of this for us. I'm not familiar with React, otherwise I'd submit a PR to implement it.

@likeazir
Copy link

So, I really wanted to use cinny on mobile with true reliable background notification support, so i looked into fcm webpush and hacked some crude notifications into the app.
However, I have never touched javascript or anything web related before so it's really messy at the moment and very much work in progress.
Maybe I'll do a PR when I have the time to clean it up and do it properly.
Just putting it out there if someone else is working on this :)

@williamkray
Copy link

So, I really wanted to use cinny on mobile with true reliable background notification support, so i looked into fcm webpush and hacked some crude notifications into the app. However, I have never touched javascript or anything web related before so it's really messy at the moment and very much work in progress. Maybe I'll do a PR when I have the time to clean it up and do it properly. Just putting it out there if someone else is working on this :)

you, uh, had any time to put this somewhere that someone else could see it by any chance @likeazir ?

@likeazir
Copy link

notification

@williamkray as far as I could tell, proper support would involve putting lots of the matrix code into a service worker to decrypt the notification.
Even when I settled for not decrypting notifications, I ended up with a mess. So unfortunately this is not something I can do at this time.

@ilar
Copy link

ilar commented Mar 7, 2025

Why not just display that there WAS a message, for encrypted messages? That's what Cinny does on desktop, and would at least make for MVP release. Since most people that are big into E2EE stuff probably wouldn't want their notifications leaking information anyway, decrypting the notification to see what it actually was would be a low priority.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
type: feature New feature or request
Projects
Status: ⚒️ PWA, 1-1 Calls, i18n and Threads
Development

No branches or pull requests