Skip to content
This repository has been archived by the owner on Dec 5, 2023. It is now read-only.

Add ABORTED state #45

Merged
merged 1 commit into from
Feb 17, 2022
Merged

Add ABORTED state #45

merged 1 commit into from
Feb 17, 2022

Conversation

jkeifer
Copy link
Member

@jkeifer jkeifer commented Feb 16, 2022

Works like FAILED in that it allows rerunning jobs, but doesn't have an associated last error message. Closes #44.

@jkeifer jkeifer added this to the 0.7.0 milestone Feb 16, 2022
@jkeifer jkeifer requested a review from trevorskaggs February 16, 2022 23:43
@jkeifer jkeifer self-assigned this Feb 16, 2022
@jkeifer
Copy link
Member Author

jkeifer commented Feb 16, 2022

I had challenges with the ordering of the class-based tests, so I converted the tests to use pytest more idiomatically, hence the large diff for the statedb tests.

@codecov-commenter
Copy link

codecov-commenter commented Feb 16, 2022

Codecov Report

Merging #45 (f7992cd) into main (b01f2e2) will increase coverage by 0.34%.
The diff coverage is 88.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #45      +/-   ##
==========================================
+ Coverage   69.43%   69.77%   +0.34%     
==========================================
  Files           5        5              
  Lines         615      622       +7     
==========================================
+ Hits          427      434       +7     
  Misses        188      188              
Impacted Files Coverage Δ
src/cirrus/lib/process_payload.py 50.62% <0.00%> (ø)
src/cirrus/lib/statedb.py 87.06% <100.00%> (+0.46%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b01f2e2...f7992cd. Read the comment docs.

Copy link
Contributor

@trevorskaggs trevorskaggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@jkeifer jkeifer merged commit 64f7cd1 into main Feb 17, 2022
@jkeifer jkeifer deleted the add-aborted-state branch February 17, 2022 19:32
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support ABORTED state
3 participants