Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

set exit status appropriately, and skip stack trace in CLI mode #7

Merged

Conversation

ircwaves
Copy link
Member

@ircwaves ircwaves commented Nov 2, 2023

No description provided.

Copy link

codecov bot commented Nov 2, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e91faa2) 69.40% compared to head (0967d0a) 70.78%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main       #7      +/-   ##
==========================================
+ Coverage   69.40%   70.78%   +1.37%     
==========================================
  Files           8        8              
  Lines         572      575       +3     
==========================================
+ Hits          397      407      +10     
+ Misses        175      168       -7     
Files Coverage Δ
src/cirrus/plugins/management/commands/manage.py 72.36% <100.00%> (+2.56%) ⬆️
src/cirrus/plugins/management/deployment.py 58.26% <100.00%> (+1.65%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ircwaves ircwaves force-pushed the make-call-set-exit-code-correctly branch from 7f8ed74 to c307c91 Compare November 2, 2023 19:23
@ircwaves ircwaves merged commit 4f82880 into cirrus-geo:main Nov 2, 2023
6 checks passed
@ircwaves ircwaves deleted the make-call-set-exit-code-correctly branch November 6, 2023 15:19
@ircwaves ircwaves mentioned this pull request Feb 16, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant