Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Ddiabe refactored dashboards 2.0 #482

Closed
wants to merge 5 commits into from

Conversation

ddiabe
Copy link
Collaborator

@ddiabe ddiabe commented Oct 23, 2024

πŸ—£ Description

πŸ’­ Motivation and context

πŸ“· Screenshots (DELETE IF UNAPPLICABLE)

πŸ§ͺ Testing

βœ… Pre-approval checklist

  • There is a gitIssue that this PR resolves
  • Git Issue that this PR solves has been selected in the Development section
  • The PR's base branch has been modified to be the proper branch.
  • Changes are limited to a single goal AND
    the title reflects this in a clear human readable format
  • Issue that this PR solves has been selected in the Development section
  • I have read and agree to LME's CONTRIBUTING.md document.
  • The PR adheres to LME's requirements in RELEASES.md
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated to reflect the changes in this PR.

βœ… Pre-merge Checklist

  • All tests pass.
  • PR has been tested and the documentation for testing is above.
  • Squash and merge all commits into one PR level commit.

βœ… Post-merge Checklist

  • Delete the branch to keep down number of branches.
  • The PR is labeled with feat for an added new feature, update for an update, OR fix for a fix.
  • The PR contains Resolves #<issue #> so that merging it closes out the corresponding issue. For example Resolves #132.

@ddiabe ddiabe self-assigned this Oct 23, 2024
@mreeve-snl
Copy link
Collaborator

I'm going to pull these into the elastalert-2 branch and put them at the correct directory

@rgbrow1949
Copy link
Contributor

I'm going to pull these into the elastalert-2 branch and put them at the correct directory

Sounds good

@mreeve-snl
Copy link
Collaborator

mreeve-snl commented Oct 24, 2024

they're added now to elastalert-2 branch :) (git cherry-pick was able to merge from this one into elastalert-2 and keep divines credit/commits LINK )
1663e12
going to close this now

@mreeve-snl mreeve-snl closed this Oct 24, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
Status: βœ… Done
Development

Successfully merging this pull request may close these issues.

4 participants