Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix reference to docker-compose in README #47

Merged
merged 1 commit into from
Jun 23, 2022

Conversation

jsf9k
Copy link
Member

@jsf9k jsf9k commented Jun 8, 2022

🗣 Description

This pull request updates README.md to use the docker compose syntax instead of the docker-compose syntax.

💭 Motivation and context

The docker compose syntax is the preferred (and only correct) syntax after the changes in cisagov/ansible-role-docker#60.

🧪 Testing

Automated testing passes.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated to reflect the changes in this PR.
  • All new and existing tests pass.

@jsf9k jsf9k added the documentation This issue or pull request improves or adds to documentation label Jun 8, 2022
@jsf9k jsf9k self-assigned this Jun 8, 2022
@jsf9k
Copy link
Member Author

jsf9k commented Jun 8, 2022

Note that the linting checks will pass once cisagov/skeleton-docker#79 is merged and flows down to this repo.

@jsf9k jsf9k added the blocked This issue or pull request is awaiting the outcome of another issue or pull request label Jun 8, 2022
@jsf9k jsf9k marked this pull request as ready for review June 8, 2022 18:22
@jsf9k jsf9k requested a review from dav3r as a code owner June 8, 2022 18:22
Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stunning!

@dav3r dav3r requested review from felddy and mcdonnnj June 8, 2022 18:33
@jsf9k jsf9k force-pushed the documentation/update-docker-compose-syntax branch from 7848d30 to 64dd6ec Compare June 23, 2022 13:42
@jsf9k
Copy link
Member Author

jsf9k commented Jun 23, 2022

Note that the linting checks will pass once cisagov/skeleton-docker#79 is merged and flows down to this repo.

cisagov/skeleton-docker#79 has been merged and has flowed down to this repo via #49. As predicted, the linting checks now pass.

@jsf9k jsf9k merged commit e02a378 into develop Jun 23, 2022
@jsf9k jsf9k deleted the documentation/update-docker-compose-syntax branch June 23, 2022 17:58
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
blocked This issue or pull request is awaiting the outcome of another issue or pull request documentation This issue or pull request improves or adds to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants