Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Use the latest version of cisagov/guacscanner #52

Merged
merged 3 commits into from
Sep 29, 2022
Merged

Use the latest version of cisagov/guacscanner #52

merged 3 commits into from
Sep 29, 2022

Conversation

jsf9k
Copy link
Member

@jsf9k jsf9k commented Sep 28, 2022 •
edited
Loading

🗣 Description

This pull request changes the Docker composition to use the latest version of the cisagov/guacscanner Docker image.

💭 Motivation and context

The latest Docker image should function identically to the old one, but with potentially better performance. See the following PRs for more details:

🧪 Testing

All automated tests pass.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All new and existing tests pass.

✅ Pre-merge checklist

  • Finalize version.

✅ Post-merge checklist

  • Create a release.

@jsf9k jsf9k added improvement This issue or pull request will add or improve functionality, maintainability, or ease of use version bump This issue or pull request increments the version number labels Sep 28, 2022
@jsf9k jsf9k self-assigned this Sep 28, 2022
@jsf9k jsf9k requested a review from dav3r as a code owner September 28, 2022 20:17
@jsf9k jsf9k marked this pull request as draft September 28, 2022 20:17
jsf9k added a commit to cisagov/ansible-role-guacamole that referenced this pull request Sep 28, 2022
@jsf9k
Install the latest version of the Guacamole Docker composition
d390ff5 
See cisagov/guacamole-composition#52 for more details.
@jsf9k jsf9k mentioned this pull request Sep 28, 2022
Merged
7 tasks
@jsf9k jsf9k marked this pull request as ready for review September 29, 2022 15:00
@jsf9k jsf9k requested a review from mcdonnnj September 29, 2022 15:01
@jsf9k jsf9k requested a review from felddy as a code owner September 29, 2022 15:02
dav3r
dav3r approved these changes Sep 29, 2022
View reviewed changes
Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤯

mcdonnnj
mcdonnnj approved these changes Sep 29, 2022
View reviewed changes
Copy link
Member

@mcdonnnj mcdonnnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@jsf9k jsf9k merged commit aeaf8a3 into develop Sep 29, 2022
@jsf9k jsf9k deleted the improvement/use-the-latest-version-of-guacscanner branch September 29, 2022 15:39
@jsf9k jsf9k mentioned this pull request Sep 29, 2022
Merged
10 tasks
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@dav3r dav3r dav3r approved these changes

@mcdonnnj mcdonnnj mcdonnnj approved these changes

@felddy felddy Awaiting requested review from felddy felddy is a code owner

Assignees

@jsf9k jsf9k

Labels
improvement This issue or pull request will add or improve functionality, maintainability, or ease of use version bump This issue or pull request increments the version number
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jsf9k @dav3r @mcdonnnj