Add brainpoolP256r1 curve support #421
Conversation
lib/algorithms/helpers.js
Outdated
| } | ||
|
|
||
| try { | ||
| promise = Promise.resolve(nodejs.apply(null, args)); | ||
| promise = promise.catch(check); |
There was a problem hiding this comment.
nodejs.apply(null, args) is a synchronous operation so i think this statement is unreachable.
There was a problem hiding this comment.
@aaccenture good point! nodejs.apply is a synchronous function that can throw. However, it also returns a promise that can reject. Hence we need to both wrap the call in a try/catch, and call promise.catch here. I'll add a comment to clarify.
There was a problem hiding this comment.
Thanks for the link, I saw return Promise.reject() so this catch here save us from unhandled promise rejection. Legitimate.
|
Hi! |
The brainpoolP256r1 curve is defined in RFC 5639, and is a recommended standard (PDF) by the German Ministry for Information Security. This curve is used in several of the German healthcare system's digitization standards (PDF; and also in German, sorry) for authenticating with various specialist services.