Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

add UCL Press style based on Chicago note #7376

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

maaxlong
Copy link

@maaxlong maaxlong commented Jan 7, 2025

No description provided.

Copy link

github-actions bot commented Jan 7, 2025

Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update this pull request, visit the "Files changed" tab above, click on the ellipsis button in the top-right corner of your style, and then select "Edit file" to start editing:

If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable.

Copy link

github-actions bot commented Jan 7, 2025

😟 There are some issues with your submission.

3 tests failed

ucl-university-college-london-press-chicago: must define all macros that are called by <text/> and <key/> elements

expected `{"access"=>#<CSL::Style::Macro name="access" children=[1]>, "archive"=>#<CSL::Style::Macro name="arch...name="title-short" children=[1]>, "translator"=>#<CSL::Style::Macro name="translator" children=[1]>}.has_key?("locators-join-with-comma")` to be truthy, got false

ucl-university-college-london-press-chicago: may not have any unused macros

expected: []
     got: ["archive-note", "editor-translator", "interviewer-note", "issue-note-join-with-comma", "issue-note-j...oin-with-space", "locators-note-join-with-comma", "locators-note-join-with-space", "point-locators"]

(compared using ==)

ucl-university-college-london-press-chicago: style ID must be of the form "http://www.zotero.org/styles/" + style file name (without ".csl" extension, e.g. "http://www.zotero.org/styles/apa")

expected: "http://www.zotero.org/styles/ucl-university-college-london-press-chicago"
     got: "http://www.zotero.org/styles/ucl-press-note"

(compared using ==)

Please check the test report for details.

Copy link

github-actions bot commented Jan 7, 2025

😟 There are some issues with your submission.

1 test failed

ucl-university-college-london-press-chicago: may not have any unused macros

expected: []
     got: ["issue-note", "locators-note"]

(compared using ==)

Please check the test report for details.

Copy link

github-actions bot commented Jan 7, 2025

😟 There are some issues with your submission.

1 test failed

ucl-university-college-london-press-chicago: may not have any unused macros

expected: []
     got: ["edition-note", "event-note", "reprint-note"]

(compared using ==)

Please check the test report for details.

Copy link

github-actions bot commented Jan 7, 2025

😃 Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

ucl-university-college-london-press-chicago.csl (new)
Hancké et al., Beyond Varieties of Capitalism; “CSL search by example.”
Mares, “Firms and the welfare state: When, why, and how does social policy matter to employers?”; Fenner et al., “A data citation roadmap for scholarly data repositories.”

Citation Style Editor. “CSL search by example,” 2012. Accessed December 15, 2012. http://editor.citationstyles.org/searchByExample/.
Fenner, Martin et al. “A data citation roadmap for scholarly data repositories.” Scientific Data 6, no. 1 (2019): 28. Accessed April 27, 2019. https://doi.org/10.1038/s41597-019-0031-8.
Hancké, Bob et al., eds. Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy. Oxford and New York: Oxford University Press, 2007.
Mares, Isabela. “Firms and the welfare state: When, why, and how does social policy matter to employers?” In Varieties of capitalism. The institutional foundations of comparative advantage, , edited by Peter A. Hall and David Soskice, 184–213. New York: Oxford University Press, 2001.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant