PDF preview broken on 2.1 #1194
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Duplicate #1195 :-) |
|
Actually, I think we should just remove the minified file from 2.1 as there is no official minified file available. |
ghost
assigned
|
@amercader Made a pull request that removes the file in 2.1.1. This way, the non-minified version is used. |
|
Correction: The example on http://demo.offene-daten.me/dataset/pdf-test/resource/f725204e-297b-44dd-bd1f-69764e34618b was initially NOT working. But now, after removing pdf.min.js and restarting Apache it's working. Thanks! |
|
@amercader Was this fixed in another pull request, or it's still broken? |
|
@vitorbaptista I'm not sure tbh, I'll need to investigate |
domoritz
added a commit
that referenced
this pull request
Oct 15, 2013
|
Cherry-picked into 2.1.1 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Failing on demo:
http://demo.ckan.org/dataset/pdf-test/resource/5597e098-83bb-4ffd-835b-2e94688007b8
Working:
http://demo.offene-daten.me/dataset/pdf-test/resource/f725204e-297b-44dd-bd1f-69764e34618b
@vitorbaptista :