Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Text alternative input should synchronise its value when the balloon shows up #5100

Closed
Mgsy opened this issue May 29, 2017 · 1 comment · Fixed by ckeditor/ckeditor5-image#115
Closed

Text alternative input should synchronise its value when the balloon shows up #5100

Mgsy opened this issue May 29, 2017 · 1 comment · Fixed by ckeditor/ckeditor5-image#115
Assignees
@oleq
Labels
domain:ui/ux This issue reports a problem related to UI or UX. package:image type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 11

Comments

@Mgsy
Copy link
Member

Mgsy commented May 29, 2017

Steps to reproduce

  1. Select an image.
  2. Choose "change image text alternative" from contextual toolbar.
  3. Type "test".
  4. Press "Save".
  5. Repeat step 2.
  6. Type "test2".
  7. Press "Cancel".

Current result

Text alternative changed.

Expected result

Pressing "Cancel" should abort changing text alternative.

Other informations

OS: Windows 10, Ubuntu 16.04
Release: 0.10.0
@oleq oleq changed the title "Cancel" in text alternative balloon shouldn't save changes Text alternative input should synchronise its value when the balloon shows up May 29, 2017
@oleq
Copy link
Member

oleq commented May 29, 2017 •
edited
Loading

To start off, this is a twin to https://github.com/ckeditor/ckeditor5-link/issues/78.

It may look like the previous (canceled) value has been actually saved to the model but it's not true. "Cancel" does not update the document but the value of the input is not refreshed next time when the balloon shows up.

The fix similar to https://github.com/ckeditor/ckeditor5-link/pull/120/files is what we need (a one–liner, in fact).

oleq referenced this issue in ckeditor/ckeditor5-image May 30, 2017
@oleq
Fix: Text alternative input should synchronise its value when the bal…
c2488af 
…loon shows up. Closes #114.
@oleq oleq self-assigned this May 30, 2017
szymonkups referenced this issue in ckeditor/ckeditor5-image May 31, 2017
@szymonkups
Merge pull request #115 from ckeditor/t/114
9b105ed 
Fix: Text alternative input should synchronize its value when the balloon shows up. Closes #114.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-image Oct 9, 2019
@mlewand mlewand added this to the iteration 11 milestone Oct 9, 2019
@mlewand mlewand added domain:ui/ux This issue reports a problem related to UI or UX. status:confirmed type:bug This issue reports a buggy (incorrect) behavior. package:image labels Oct 9, 2019
@oleq oleq mentioned this issue Oct 11, 2019
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@oleq oleq

Labels
domain:ui/ux This issue reports a problem related to UI or UX. package:image type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 11
3 participants
@oleq @mlewand @Mgsy