Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

CTRL+K listener should check if the command is enabled before opening the balloon #4797

Closed
Mgsy opened this issue Jun 5, 2017 · 3 comments · Fixed by ckeditor/ckeditor5-link#133
Closed

CTRL+K listener should check if the command is enabled before opening the balloon #4797

Mgsy opened this issue Jun 5, 2017 · 3 comments · Fixed by ckeditor/ckeditor5-link#133
Assignees
@oleq
Labels
domain:ui/ux This issue reports a problem related to UI or UX. package:link type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 11

Comments

@Mgsy
Copy link
Member

Mgsy commented Jun 5, 2017

Steps to reproduce

  1. Open editor's sample.
  2. Create a new line below the image.
  3. Double-click on a new line to select some blank space.
  4. Press CTRL + K.

Current result

Link balloon shows up and allows user to create a link, but after saving nothing happens.

Notes

  • On Safari after performing step 4, link balloon shows up in the top-left corner of a browser.
  • Toolbar's behavior is correct, because styling and link buttons are disabled.

GIF

bug

Other information

OS: Windows 10, MacOS X, Ubuntu 16.04
Browser: Chrome, Safari, Firefox
Release: 0.10.0
@oleq
Copy link
Member

oleq commented Jun 5, 2017

Yes, Ctrl+K listener does not check whether the command is enabled or not and just calls _showPanel. This must be fixed.

As for Safari, there's an issue for that already https://github.com/ckeditor/ckeditor5-ui/issues/126.

@oleq oleq changed the title Link balloon shouldn't show up after blank space selection CTRL+K listener should check if the command is enabled before opening the balloon Jun 5, 2017
@oskarwrobel
Copy link
Contributor

This is related to #340 (comment).

@oleq oleq self-assigned this Jul 6, 2017
oleq referenced this issue in ckeditor/ckeditor5-link Jul 6, 2017
@oleq
Fix: Keyboard listener should check if the command is enabled before …
571310b 
…opening the balloon. Closes #128.
@oleq
Copy link
Member

oleq commented Jul 6, 2017

I suppose we should somehow bind keystroke listeners and commands in such situations. It's not a big deal though at this moment.

oskarwrobel referenced this issue in ckeditor/ckeditor5-link Jul 6, 2017
@oskarwrobel
Merge pull request #133 from ckeditor/t/128
be4b9eb 
Fix: Keyboard listener should check if the command is enabled before opening the balloon. Closes #128.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-link Oct 9, 2019
@mlewand mlewand added this to the iteration 11 milestone Oct 9, 2019
@mlewand mlewand added domain:ui/ux This issue reports a problem related to UI or UX. status:confirmed type:bug This issue reports a buggy (incorrect) behavior. package:link labels Oct 9, 2019
@oleq oleq mentioned this issue Oct 11, 2019
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@oleq oleq

Labels
domain:ui/ux This issue reports a problem related to UI or UX. package:link type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 11
4 participants
@oskarwrobel @oleq @mlewand @Mgsy