Unlink option is missing when part of a link selected

[Reinmar]

[Reinmar]

This is serious because you can't type after a link now so the only option to do that was to type and then unlink part of that.

[oleq]

I'm wondering which part of https://github.com/ckeditor/ckeditor5-link/blob/master/src/unlinkcommand.js#L40-L41 has failed 🤔

[Reinmar]

You mean rather https://github.com/ckeditor/ckeditor5-link/blob/master/src/unlinkcommand.js#L23. The command isn't even executed.

[oleq]

Yes, you're right. It's funny selection.hasAttribute() fails to discover the attribute in such boundary case. Maybe something's wrong with editing<->model synchronization?

[Reinmar]

Doesn't look like it still:

[oleq]

The presence of the unlink button is controlled by the _getSelectedLinkElement, which works fine for the balloon as a whole (showing up on "click", positioning, etc.) because it checks if the link is fully selected and otherwise returns null.

What we need to do is connect the presence of the unlink button with the state of the unlink command.