Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Remove DeleteObserver #3064

Closed
Reinmar opened this issue Oct 19, 2016 · 3 comments
Closed

Remove DeleteObserver #3064

Reinmar opened this issue Oct 19, 2016 · 3 comments
Labels
package:typing resolution:invalid This issue is invalid (e.g. reports a non-existent bug or a by-design behavior). status:discussion type:task This issue reports a chore (non-production change) and other types of "todos".

Comments

@Reinmar
Copy link
Member

Reinmar commented Oct 19, 2016

Just like https://github.com/ckeditor/ckeditor5-enter/issues/31.
@Reinmar
Copy link
Member Author

Reinmar commented Feb 9, 2017

I'm less sure now about removing this observer. Taken that one day the entire Typing feature will use the native beforeinput event, having an abstraction for it makes a lot of sense. And in this case, both, input and deleting needs to be abstracted.

In fact, the enter support will (or at least, should be) be a part of beforeinput too, so removing the EnterObserver makes no sense too.

@Reinmar
Copy link
Member Author

Reinmar commented May 4, 2018

OK, I made a decision. DeleteObserver is a very special case and should stay.

@Reinmar Reinmar closed this as completed May 4, 2018
@Reinmar
Copy link
Member Author

Reinmar commented May 4, 2018

Explanation can be found here: https://github.com/ckeditor/ckeditor5-enter/issues/2#issuecomment-386607029

@mlewand mlewand transferred this issue from ckeditor/ckeditor5-typing Oct 9, 2019
@mlewand mlewand added resolution:invalid This issue is invalid (e.g. reports a non-existent bug or a by-design behavior). status:discussion type:task This issue reports a chore (non-production change) and other types of "todos". package:typing labels Oct 9, 2019
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
package:typing resolution:invalid This issue is invalid (e.g. reports a non-existent bug or a by-design behavior). status:discussion type:task This issue reports a chore (non-production change) and other types of "todos".
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Reinmar @mlewand