Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Style dropdown] Inline styles retained when changing heading, inserting codeblock #11591

Closed
Tracked by #14274
mateuszzagorski opened this issue Apr 7, 2022 · 2 comments
Labels
package:style squad:core Issue to be handled by the Core team. type:bug This issue reports a buggy (incorrect) behavior.

Comments

@mateuszzagorski
Copy link
Contributor

📝 Provide detailed reproduction steps (if any)

Changing heading:

ckeditor5-style_retain_styles.mov

Inserting codeblock:

ckeditor5-style_retain_styles_2.mov

✔️ Expected result

I'd expect that by changing the heading/inserting codeblock:

  1. All of the added htmlAttributes will be removed.
  2. At least all of the htmlAttributes that cant be unchecked should be removed.

❌ Actual result

All of the htmlAttributes added are available, even though there is no way of removing them.


If you'd like to see this fixed sooner, add a 👍 reaction to this post.

@mateuszzagorski mateuszzagorski added type:bug This issue reports a buggy (incorrect) behavior. squad:core Issue to be handled by the Core team. package:style labels Apr 7, 2022
@mateuszzagorski mateuszzagorski changed the title [Style dropdown] Inline styles retained when changing heading, inserting codeblock. [Style dropdown] Inline styles retained when changing heading, inserting codeblock Apr 7, 2022
@Reinmar
Copy link
Member

Reinmar commented Apr 11, 2022

This will probably be resolved by #11606.

@Witoso
Copy link
Member

Witoso commented Jun 5, 2023

Solved by: #14216.

@Witoso Witoso closed this as completed Jun 5, 2023
@Witoso Witoso added this to the iteration 64 milestone Jun 5, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
package:style squad:core Issue to be handled by the Core team. type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Development

No branches or pull requests

3 participants