Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

refactor: simplify /health handler #61

Merged
merged 2 commits into from
Jan 4, 2025
Merged

refactor: simplify /health handler #61

merged 2 commits into from
Jan 4, 2025

Conversation

clambin
Copy link
Owner

@clambin clambin commented Jan 4, 2025

Just check dependencies. No need to report statistics: we have instrumentation for that.

Copy link

codecov bot commented Jan 4, 2025

Codecov Report

Attention: Patch coverage is 94.11765% with 1 line in your changes missing coverage. Please review.

Project coverage is 94.23%. Comparing base (bbae5bb) to head (bfe4b3f).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
internal/server/handlers.go 94.11% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #61      +/-   ##
==========================================
+ Coverage   92.86%   94.23%   +1.36%     
==========================================
  Files          19       19              
  Lines         701      694       -7     
==========================================
+ Hits          651      654       +3     
+ Misses         41       33       -8     
+ Partials        9        7       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@clambin clambin merged commit 9419da2 into main Jan 4, 2025
9 checks passed
@clambin clambin deleted the health branch January 4, 2025 15:41
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant