New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix(parser): Allow multiple value terminated positionals #4924

Merged

epage merged 3 commits into clap-rs:master from epage:term2

May 19, 2023

Member

epage commented May 19, 2023

While this doesn't directly address #4919, this fixes problems around it

One value terminated positional was allowed, but a second would hit asserts relate to last
The parser didn't correctly update the state when multiple were present (yet somehow it worked when followed by a single value)

epage added 3 commits

May 19, 2023 10:36


          test(parser): Show multiple positional multiple values behavior

130b2ff


          fix(builder): Allow value terminated multiple positional values

1ee2e95


          fix(parser): Ensure terminated positionals are assigned correctly

e1db168

epage merged commit d5bea65 into clap-rs:master

epage deleted the term2 branch

May 19, 2023 16:02

epage mentioned this pull request

test(parser): Verify value terminator precedence #4925

Merged

# for free to join this conversation on GitHub. Already have an account? # to comment

Labels

None yet