Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Use correct value for default username in database #2

Merged
merged 1 commit into from
Apr 24, 2023
Merged

Use correct value for default username in database #2

merged 1 commit into from
Apr 24, 2023

Conversation

kevin-fitlg
Copy link
Contributor

The module uses a the for_each key as the default username in target database which is not correct. This is also different from what appears in the output connection string;

This PR fixes the code to use correct attribute of the local.database_users for username.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Changes proposed in this pull request

  • Use the correct value for username

@claranet/fr-azure-reviewers

@BzSpi BzSpi merged commit 51a95d4 into claranet:master Apr 24, 2023
Shr3ps pushed a commit that referenced this pull request Apr 26, 2023
@BzSpi
Merge pull request #2 from kevin-fitlg/patch-1
7471ccb 
Use correct value for default username in database
Shr3ps pushed a commit that referenced this pull request Apr 26, 2023
@BzSpi
GH-2: Update CHANGELOG
6c0c4cc
Shr3ps added a commit that referenced this pull request Apr 26, 2023
@Shr3ps
Merge branch 'GH-2-fix-username' into 'master'
1ae64c1 
GH-2: Fix databases usernames

Closes GH-2

See merge request claranet/projects/cloud/azure/terraform/modules/db-sql!51
Shr3ps added a commit that referenced this pull request Apr 26, 2023
@Shr3ps
Prepare v7.2.4
34fb5d9 
Fixed
  * AZ-387: Fix README
  * [GH-2](#2): Fix databases usernames
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@BzSpi BzSpi BzSpi approved these changes

@Shr3ps Shr3ps Awaiting requested review from Shr3ps Shr3ps is a code owner

@rossifumax rossifumax Awaiting requested review from rossifumax rossifumax is a code owner

@jmapro jmapro Awaiting requested review from jmapro jmapro is a code owner

@maxpoullain maxpoullain Awaiting requested review from maxpoullain maxpoullain is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kevin-fitlg @BzSpi