fix(docs): minor typo #45
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obycode
reviewed
Mar 8, 2023
| @@ -161,7 +161,7 @@ admit lists, tuples only admit tuples, bools only admit bools. | |||
| * A list type `A` admits another list type `B` iff `A.max-len >= B.max-len` and | |||
| `A.entry-type` admits `B.entry-type`. | |||
| * A buffer type `A` admits another buffer type `B` iff `A.max-len >= B.max-len`. | |||
| * An optional type `A` admits another optional type `B` iff: | |||
| * An optional type `A` admits another optional type `B` if: | |||
There was a problem hiding this comment.
Is the thinking here that "iff" doesn't make sense since there is an "or"?
There was a problem hiding this comment.
I think the iff makes sense here but maybe it adds unnecessary complexity for people unfamiliar with it?
I'd say it can be merged 👍
There was a problem hiding this comment.
Maybe we should just expand all of the "iff"s to "if and only if"?
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.