Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

add test-random-integer #1333

Merged

Conversation

kpoeck
Copy link
Contributor

@kpoeck kpoeck commented Jun 6, 2022

  • run pf dietz random integer test

  • run as ninja -C build test-random-integer i default configuration

  • or run as e.g. random_int_size=5 random_int_variables=2 random_int_iterations=1000 ninja -C build test-random-integerspecifying:

    • the size of the expression
    • the number of variables
    • the number of iterations
  • currently finds compiler errors in clasp in every run

  • outputs e.g. the following as an error (I did report them)

(:VARS (A B) :FORM
 (IF T
     (IF B -311 -359726514120)
     (LOOP FOR
           LV2
           BELOW
           3
           SUM
           (BLOCK B6
             (BLOCK B8
               (IF B 258 (LOGNAND 2199023255557 (RETURN-FROM B6 A)))))))
 :VAR-TYPES ((INTEGER 1 14) BOOLEAN) :VALS (3 NIL) :LAMBDA-FORM
 (LAMBDA (A B)
   (DECLARE (TYPE (INTEGER 1 14) A))
   (DECLARE (TYPE BOOLEAN B))
   (DECLARE (IGNORABLE A B))
   (DECLARE
    (OPTIMIZE (COMPILATION-SPEED 0) (SPACE 1) (DEBUG 0) (SPEED 1) (SAFETY 3)))
   (IF T
       (IF B -311 -359726514120)
       (LOOP FOR
             LV2
             BELOW
             3
             SUM
             (BLOCK B6
               (BLOCK B8
                 (IF B 258 (LOGNAND 2199023255557 (RETURN-FROM B6 A))))))))
 :DECLS1 ((COMPILATION-SPEED 0) (SPACE 1) (DEBUG 0) (SPEED 1) (SAFETY 3))
 :DECLS2 ((SAFETY 3) (DEBUG 1) (COMPILATION-SPEED 0) (SPEED 3) (SPACE 3))
 :COMPILER-CONDITION "#<CLEAVIR-BIR::VERIFICATION-FAILED>")
  • the expression in the :LAMBDA-FORMgives the form that gives an error - here #CLEAVIR-BIR::VERIFICATION-FAILED

@kpoeck
Copy link
Contributor Author

kpoeck commented Jun 6, 2022

@yitzchak can you please check

@yitzchak yitzchak self-requested a review June 6, 2022 12:05
Copy link
Member

@yitzchak yitzchak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Ran with default values and several variations of the input variables with no problems.

@Bike Bike merged commit 9f3efbe into clasp-developers:main Jun 6, 2022
@kpoeck kpoeck deleted the feature-run-random-integer-tests branch June 6, 2022 13:16
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants