Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Do not fail at building Riemann solvers when LAPACK is not linkable #63

Closed
mandli opened this issue Feb 15, 2014 · 1 comment · Fixed by #64
Closed

Do not fail at building Riemann solvers when LAPACK is not linkable #63

mandli opened this issue Feb 15, 2014 · 1 comment · Fixed by #64

Comments

@mandli
Copy link
Member

mandli commented Feb 15, 2014

Need to not include the LAPACK linking flags when building Riemann solvers that do not need them and fail gracefully when a solver needs them.
@mandli
Copy link
Member Author

mandli commented Feb 15, 2014

Note that this could be partially fixed by changing the lines in setup.py containing

config.add_extension(rp_ext, rp_src, **lapack_args)

to not include **lapack_args unless necessary. For those that require them, could we add a try-except block around a separate setup call maybe?

@ketch ketch mentioned this issue Feb 16, 2014
Merged
@mandli mandli mentioned this issue Feb 20, 2014
Open
mandli added a commit to mandli/riemann that referenced this issue Mar 19, 2015
@mandli
Merge pull request clawpack#63 from rjleveque/rm_3d_gauges_regions
76420c5 
pass num_dim into RegionData and GaugeData to print error if num_dim==3
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Dont fail if layered shallow water solver won't compile ketch/riemann
1 participant
@mandli