Skip to content
This repository has been archived by the owner on May 6, 2020. It is now read-only.

scripts: relnotes: limitations link was broken during script move #519

Closed
grahamwhaley opened this issue Sep 5, 2017 · 0 comments
Closed

Comments

@grahamwhaley
Copy link
Contributor

When the relnotes script moved during #489 we forgot to update the relpath link to the limitations.md file.

grahamwhaley pushed a commit to grahamwhaley/runtime that referenced this issue Sep 5, 2017
When we moved the script to a new directory we broke the relpath
link to the limitations.md file. Fix it.

Fixes: clearcontainers#519

Signed-off-by: Graham Whaley <graham.whaley@intel.com>
grahamwhaley pushed a commit to grahamwhaley/runtime that referenced this issue Sep 11, 2017
When we moved the script to a new directory we broke the relpath
link to the limitations.md file. Fix it.

Fixes: clearcontainers#519

Signed-off-by: Graham Whaley <graham.whaley@intel.com>
mcastelino pushed a commit to mcastelino/runtime that referenced this issue Dec 6, 2018
Now that the `SetLogger()` functions accept a `logrus.Entry`, they can
access the fields that have already been set for the logger and
re-apply them if `SetLogger()` is called multiple times.

This fixes a bug whereby the logger functions -- which are necessarily
called multiple times [1] -- previously ended up applying any new fields
the specified logger contained, but erroneously removing any additional
fields added since `SetLogger()` was last called.

Partially fixes clearcontainers#519.

--
[1] - kata-containers/runtime#468

Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
mcastelino pushed a commit to mcastelino/runtime that referenced this issue Dec 6, 2018
Refine the changes made on clearcontainers#468 by adding the containerID log field as
soon as possible (before *any* virtcontainers calls). This requires
that `setExternalLoggers()` be called more times, but it's essential to
ensure the correct log fields are available as early as possible.

Partially fixes clearcontainers#519.

Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
mcastelino pushed a commit to mcastelino/runtime that referenced this issue Dec 6, 2018
PR clearcontainers#468 neglected to update the `update` command.

Fixes clearcontainers#519.

Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant