Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

deprecate config TRIMMED_DEFINITION_MONGO_COLLECTION_NAME #1046

Merged
merged 1 commit into from
Feb 9, 2024

Conversation

elrayle
Copy link
Collaborator

@elrayle elrayle commented Feb 9, 2024

NOTE: This is merging into prod branch to allow release of v1.1.0 as a minor release.. It will be backported to master branch.


Deprecated config: TRIMMED_DEFINITION_MONGO_COLLECTION_NAME
Replacement config: DEFINITION_MONGO_TRIMMED_COLLECTION_NAME

Config TRIMMED_DEFINITION_MONGO_COLLECTION_NAME was removed in PR #987. To avoid a major version change in the next release, the config is being added back in and deprecated.

New processing:

  • if the old config has a value, a deprecation message is written to the console
  • if the new config is specified, its value is used and the old one is ignored if it exists
  • if only the old config is specified, its value is used
  • otherwise, if neither are specified, the default is used

**NOTE: This is merging into prod branch to allow release of v1.1.0 as a minor release.**. It will be backported to master branch.

----

Deprecated config: TRIMMED_DEFINITION_MONGO_COLLECTION_NAME
Replacement config: DEFINITION_MONGO_TRIMMED_COLLECTION_NAME

Config TRIMMED_DEFINITION_MONGO_COLLECTION_NAME was removed in PR #987. To avoid a major version change in the next release, the config is being added back in and deprecated.

New processing:

- if the old config has a value, a deprecation message is written to the console
- if the new config is specified, its value is used and the old one is ignored if it exists
- if only the old config is specified, its value is used
- otherwise, if neither are specified, the default is used
Copy link
Collaborator

@qtomlinson qtomlinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix!

@elrayle elrayle merged commit f4cc656 into prod Feb 9, 2024
1 check passed
@elrayle elrayle deleted the elr/prod-mongo-config branch February 9, 2024 21:48
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants