Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix originConda route #1113

Merged
merged 1 commit into from
May 7, 2024
Merged

Conversation

qtomlinson
Copy link
Collaborator

@qtomlinson qtomlinson commented May 7, 2024

Service App fails to start with the following exception:
service-1 | Exception:
service-1 | TypeError: Cannot read properties of undefined (reading 'params')
service-1 | at getOriginCondaRevisions (/opt/service/routes/originConda.js:40:43)
service-1 | at Object. (/opt/service/routes/originConda.js:37:65)
service-1 | at Module._compile (node:internal/modules/cjs/loader:1364:14)
service-1 | at Module._extensions..js (node:internal/modules/cjs/loader:1422:10)
service-1 | at Module.load (node:internal/modules/cjs/loader:1203:32)
service-1 | at Module._load (node:internal/modules/cjs/loader:1019:12)
service-1 | at Module.require (node:internal/modules/cjs/loader:1231:19)
service-1 | at Module.patchedRequire [as require] (/opt/service/node_modules/diagnostic-channel/dist/src/patchRequire.js:14:46)
service-1 | at require (node:internal/modules/helpers:177:18)
service-1 | at createApp (/opt/service/app.js:182:29)
service-1 | [I] Service initialized{"buildNumber":"0"}

Fix this by passing in the getOriginCondaRevisions function

@qtomlinson qtomlinson requested review from lumaxis and elrayle May 7, 2024 16:25
Copy link
Contributor

@lumaxis lumaxis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops! Thanks for catching this

@lumaxis lumaxis merged commit 73e2145 into clearlydefined:master May 7, 2024
3 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants