-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Fixed origins api for pypi components throwing 500 error when invalid package is provided #1172
Merged
elrayle
merged 12 commits into
clearlydefined:master
from
yashkohli88:yk/fix-origins-pypi-error-handling
Aug 28, 2024
Merged
Fixed origins api for pypi components throwing 500 error when invalid package is provided #1172
elrayle
merged 12 commits into
clearlydefined:master
from
yashkohli88:yk/fix-origins-pypi-error-handling
Aug 28, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor test
yashkohli88
changed the title
Fix origins pypi error handling
Fixed origins api for pypi components throwing 500 error when invalid group id is provided
Aug 21, 2024
yashkohli88
changed the title
Fixed origins api for pypi components throwing 500 error when invalid group id is provided
Fixed origins api for pypi components throwing 500 error when invalid package is provided
Aug 21, 2024
elrayle
approved these changes
Aug 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice to see 500 errors being addressed. Thanks!
@yashkohli88 The PR is marked as a work in progress. Is this ready for review? NOTE: There are some conflicts to resolve. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Below are the tasks completed as a part of this fix -
List of testcases added in the origins.js file related to the changes -
This fix is related to Issue 1182