Fix curation validation #1223
Merged
Fix curation validation #1223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the curated license contains NOASSERTION (MIT AND NOASSERTION), the curation should be invalid In addition, when the curated license is not normalized, include the normalized license expression in the error message.
|
This is related to #1181 |
elrayle
approved these changes
Nov 6, 2024
| expect(curation.errors[0].error).to.equal( | ||
| '/foo in 4.17.4 files with value "mit and apache-2.0" is not SPDX compliant' | ||
| ) | ||
| describe('declared licenses', () => { |
There was a problem hiding this comment.
I appreciate all the tests. Makes it very clear what is happening.
| errors.push(`${source} with value "${license}" is not SPDX compliant`) | ||
| } else if (parsed !== license) { | ||
| errors.push(`${source} with value "${license}" is not normalized. Suggest using "${parsed}"`) |
There was a problem hiding this comment.
This is excellent feedback to the creator of the curation.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the curated license contains NOASSERTION (e.g., MIT AND NOASSERTION), the curation should be invalid. In addition, when the curated license is not normalized, include the normalized license expression in the error message.
In the future, we can consider ignoring the cases of SPDX identifiers as per SPDX specification. For example, "MIT, Mit and mIt should all be treated as the same identifier".