Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Publish package to github #32

Merged
merged 3 commits into from
Sep 26, 2024
Merged

Publish package to github #32

merged 3 commits into from
Sep 26, 2024

Conversation

ljones140
Copy link
Contributor

What

Adds Action to publish the node module to GitHub packages.

Why

Getting access to the NPM account that this publishes to is difficult.
Putting on GitHub means package can be deployed easily by contributors with access the GitHub org and or repo.

Quick solution to unblock the service that depends on this pacakge

Copy link

@RomanIakovlev RomanIakovlev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good from technical side, but I wasn't part of discussion on moving this package to another registry, so I just approve the implementation details here. If moving the package has been discussed and approved by someone elsewhere, it would be nice to link it here.

@ljones140
Copy link
Contributor Author

The change looks good from technical side, but I wasn't part of discussion on moving this package to another registry, so I just approve the implementation details here. If moving the package has been discussed and approved by someone elsewhere, it would be nice to link it here.

Good point @RomanIakovlev

I discussed it with @elrayle yesterday and they approved it

@elrayle
Copy link

elrayle commented Sep 26, 2024

@RomanIakovlev This is discussed in the original issue. It was also discussed at the last ClearlyDefined Dev meeting, but the notes there aren't complete on this topic.

@elrayle elrayle deleted the publish-package-to-github branch September 26, 2024 20:23
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants