Score Rendering improvements #713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've also added a link to the documentation which completes and fixes #652 |
geneh
reviewed
May 29, 2019
| {this.renderScore(tools)} | ||
| </div> | ||
| </div> | ||
| ) | ||
| } | ||
|
|
||
| renderUnit = () => ( | ||
| <span> | ||
| / 100 <span className="unit">points</span> |
There was a problem hiding this comment.
Let's drop "points" everywhere and make sure the spacing around the slash is even.
| href="https://github.com/clearlydefined/license-score/blob/master/ClearlyLicensedMetrics.md#clearlylicensed-scoring-formula" | ||
| target="_blank" | ||
| > | ||
| What does these scores mean? |
There was a problem hiding this comment.
Let's change it to "Scoring formula"
|
👍 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is related to #652
This is how the tooltip looks like after the suggested changes:
This implementation still miss one of the suggested changes, about link the titles to a document, that is not yet be written.