-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
fix(clerk-js): Rethrow errors if not requires_captcha during init #4812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: a492dee The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
panteliselef
approved these changes
Dec 19, 2024
anagstef
approved these changes
Dec 19, 2024
octoper
approved these changes
Dec 19, 2024
octoper
reviewed
Dec 19, 2024
"@clerk/clerk-js": patch | ||
--- | ||
|
||
fix(clerk-js): Rethrow errors if not requires_captcha during init |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
fix(clerk-js): Rethrow errors if not requires_captcha during init | |
Rethrow errors if not requires_captcha during init |
brkalow
pushed a commit
that referenced
this pull request
Dec 20, 2024
jakobevangelista
pushed a commit
that referenced
this pull request
Jan 9, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Rethrow unrelated errors during init so they can be caught by the normal retry mechanism that existed before the fraud engine changes
Checklist
pnpm test
runs as expected.pnpm build
runs as expected.Type of change