Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Commit without changes results in weird diff #161

Closed
krihal opened this issue Nov 23, 2024 · 2 comments
Closed

Commit without changes results in weird diff #161

krihal opened this issue Nov 23, 2024 · 2 comments
Assignees
Labels
bug Something isn't working fixed: plz verify Bug/feature is fixed by developer, need verification

Comments

@krihal
Copy link
Collaborator

krihal commented Nov 23, 2024

In this example there should be and empty diff:

debian@khn-dev:~$ clixon_cli
debian@khn-dev> connection open
debian@khn-dev> show connections
Name                    State      Time                   Logmsg
==============================================================================================================
openconfig1             OPEN       2024-11-23T10:02:22
debian@khn-dev> configure
debian@khn-dev[/]# show compare
debian@khn-dev[/]# commit
OK
debian@khn-dev[/]# show compare
+  <processes xmlns="http://clicon.org/controller">
+     <services>
+        <enabled>false</enabled>
+     </services>
+  </processes>
+  <services xmlns="http://clicon.org/controller">
+     <ssh-users xmlns="http://clicon.org/ssh-users">
+        <created>
+           <path>/devices/device[name="openconfig1"]/config/system/aaa/authentication/users/user[username="test"]</path>
+        </created>
+        <instance>test</instance>
+        <username>
+           <name>test</name>
+           <ssh-key>test</ssh-key>
+           <role>test</role>
+        </username>
+     </ssh-users>
+  </services>
+  <devices xmlns="http://clicon.org/controller">
+     <device-profile>
+        <name>OpenConfig</name>
+        <user>noc</user>
+        <conn-type>NETCONF_SSH</conn-type>
+        <device-domain>openconfig</device-domain>
+     </device-profile>
+     <device>
+        <name>openconfig1</name>
+        <device-profile>OpenConfig</device-profile>
+        <addr>172.23.0.3</addr>
+        <config>
+           <restconf xmlns="http://clicon.org/restconf">
+              <enable>true</enable>
+              <auth-type>none</auth-type>
+              <debug>0</debug>
+              <log-destination>file</log-destination>
+              <pretty>false</pretty>
+              <socket>
+                 <namespace>default</namespace>
+                 <address>0.0.0.0</address>
+                 <port>80</port>
+                 <ssl>false</ssl>
+              </socket>
+           </restconf>
+           <system xmlns="http://openconfig.net/yang/system">
+              <aaa>
+                 <authentication>
+                    <users>
+                       <user>
+                          <username>test</username>
+                          <config>
+                             <username>test</username>
+                             <ssh-key>test</ssh-key>
+                             <role>test</role>
@krihal krihal added the bug Something isn't working label Nov 23, 2024
@olofhagsand
Copy link
Member

This is now isolated to CLICON_XMLDB_SYSTEM_ONLY_CONFIG=true

olofhagsand added a commit that referenced this issue Nov 26, 2024
Fixed: [Commit without changes results in weird diff](#161)
Test: removed most specialized autocli.xml
@olofhagsand olofhagsand added the fixed: plz verify Bug/feature is fixed by developer, need verification label Nov 26, 2024
@krihal
Copy link
Collaborator Author

krihal commented Nov 28, 2024

Verified, closing.

@krihal krihal closed this as completed Nov 28, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working fixed: plz verify Bug/feature is fixed by developer, need verification
Projects
None yet
Development

No branches or pull requests

2 participants