Feature/pdct 1780 support multiple geos in update #278

odrakes-cpr · 2025-01-08T11:01:01Z

Description

Update the update endpoint to allow for the editing of multiple geographies.

Added a separate check to the update intention which determines if the list of geo ids from the iso codes in the payload is diff from the associted family geo ids.
Added a validation step to the service layer that checks if the iso code in the payload exists in the db

Proposed version

Please select the option below that is most relevant from the list below. This
will be used to generate the next tag version name during auto-tagging.

Skip auto-tagging
Patch
Minor version
Major version

Visit the Semver website to understand the
difference between MAJOR, MINOR, and PATCH versions.

Notes:

If none of these options are selected, auto-tagging will fail
Where multiple options are selected, the most senior option ticked will be
used -- e.g. Major > Minor > Patch
If you are selecting the version in the list above using the textbox, make
sure your selected option is marked [x] with no spaces in between the
brackets and the x

Type of change

Please select the option(s) below that are most relevant:

How Has This Been Tested?

Updated the integration tests and the service / repository layer tests where appropriate

Reviewer Checklist

DB_CLIENT DEPENDENCY IS ON THE LATEST VERSION
The PR represents a single feature (small drive-by fixes are also ok)
The PR includes tests that are sufficient for the level of risk
The code is sufficiently commented, particularly in hard-to-understand areas
Any required documentation updates have been made
Any TODOs added are captured in future tickets
No FIXMEs remain

- function that retrieves the list of geo ids from the geo repo, based on the iso codes thats provided in the payload. It validates these iso codes at the same time returning an error if the geography does not exist in the db

this will currently have a default value of none, so that it works with front end requests until the payload data is also updated

linear · 2025-01-08T11:01:04Z

PDCT-1780 Support multiple geos in /update

app/repository/family.py

pyproject.toml

tests/mocks/services/family_service.py

tests/unit_tests/service/geography/test_geography_service.py

katybaulch

Nice work! Couple of comments 💬

…oes not break any requests made by the front before multi geos is implemented

if the array of geo ids coming through is empty, i.e it was not passed int he payload as expected (the frontend hasnt been updted for multi geos we do nowt and carry on

app/model/family.py

app/repository/family.py

app/repository/geography.py

…d multi geos has been implemented

…hods

app/repository/family.py

katybaulch

Missing a RepoError raise for geography add but otherwise super great, well done!!!! 🦖

app/repository/family.py

katybaulch

very nice!!!!

Osneil Drakes added 8 commits January 7, 2025 13:39

feat: add geographies onto family write dto

f400082

this will currently have a default value of none, so that it works with front end requests until the payload data is also updated

feat: add list of geo ids parameter to update function

067e801

feat: validate geography iso codes to get ids in family service

c193baf

feat: update model for family geographies

b8a47cb

test: integration tests for update endpoint with invalid geo id in list

a83ffd7

test: update dto helpers with geographies property

f4db263

chore: update project version

f8125f5

odrakes-cpr requested a review from a team as a code owner January 8, 2025 11:01

chore: update project version

2252d66

katybaulch reviewed Jan 8, 2025

View reviewed changes

app/repository/family.py Outdated Show resolved Hide resolved

katybaulch reviewed Jan 8, 2025

View reviewed changes

pyproject.toml Outdated Show resolved Hide resolved

katybaulch reviewed Jan 8, 2025

View reviewed changes

tests/mocks/services/family_service.py Outdated Show resolved Hide resolved

katybaulch reviewed Jan 8, 2025

View reviewed changes

tests/unit_tests/service/geography/test_geography_service.py Outdated Show resolved Hide resolved

katybaulch reviewed Jan 8, 2025

View reviewed changes

tests/unit_tests/service/geography/test_geography_service.py Outdated Show resolved Hide resolved

katybaulch requested changes Jan 8, 2025

View reviewed changes

Osneil Drakes added 6 commits January 8, 2025 11:24

merge main

a5d5115

tests: add final integration, testing multi geos are added

e415e55

feat: default geographies to none on the model, to ensure that this d…

b5ea5d1

…oes not break any requests made by the front before multi geos is implemented

fix: use geography repo mock in repo unit tests

b837379

chore: update project version

0981268

refactor: make update_geographies check a bit more explicit

ba5dbf7

if the array of geo ids coming through is empty, i.e it was not passed int he payload as expected (the frontend hasnt been updted for multi geos we do nowt and carry on

odrakes-cpr requested a review from katybaulch January 8, 2025 12:29

test: fixing missing argument in rollbackrepo

887470d

katybaulch reviewed Jan 8, 2025

View reviewed changes

app/model/family.py Outdated Show resolved Hide resolved

katybaulch reviewed Jan 8, 2025

View reviewed changes

app/repository/family.py Outdated Show resolved Hide resolved

katybaulch reviewed Jan 8, 2025

View reviewed changes

app/repository/family.py Outdated Show resolved Hide resolved

katybaulch reviewed Jan 8, 2025

View reviewed changes

app/repository/family.py Outdated Show resolved Hide resolved

katybaulch reviewed Jan 8, 2025

View reviewed changes

app/repository/geography.py Outdated Show resolved Hide resolved

Osneil Drakes added 4 commits January 8, 2025 16:35

feat: add linear ticket to todo comments - updating code once fronten…

cc3dee7

…d multi geos has been implemented

refactor: split out family geo update functionality into separate met…

6225bf8

…hods

feat: helper functions for pergorming familygeo updates

9133846

refactor: update sql query to be more explicit

0760231

odrakes-cpr requested a review from katybaulch January 8, 2025 16:53

refactor : move functions into family repo and out of helpers

02c9ab2

katybaulch reviewed Jan 9, 2025

View reviewed changes

app/repository/family.py Show resolved Hide resolved

katybaulch requested changes Jan 9, 2025

View reviewed changes

app/repository/family.py Show resolved Hide resolved

app/repository/family.py Outdated Show resolved Hide resolved

Osneil Drakes added 2 commits January 9, 2025 12:47

tests: add tests for repository errors

ef8e218

feat: wrap geography updates in a repository error

c6297d6

katybaulch approved these changes Jan 9, 2025

View reviewed changes

odrakes-cpr merged commit 47c9067 into main Jan 9, 2025
10 checks passed

odrakes-cpr deleted the feature/pdct-1780-support-multiple-geos-in-update branch January 9, 2025 13:03

jamesgorrie restored the feature/pdct-1780-support-multiple-geos-in-update branch February 6, 2025 15:43

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature/pdct 1780 support multiple geos in update #278

Feature/pdct 1780 support multiple geos in update #278

odrakes-cpr commented Jan 8, 2025

linear bot commented Jan 8, 2025

katybaulch left a comment

katybaulch left a comment

katybaulch left a comment

Feature/pdct 1780 support multiple geos in update #278

Feature/pdct 1780 support multiple geos in update #278

Conversation

odrakes-cpr commented Jan 8, 2025

Description

Proposed version

Type of change

How Has This Been Tested?

Reviewer Checklist

linear bot commented Jan 8, 2025

katybaulch left a comment

Choose a reason for hiding this comment

katybaulch left a comment

Choose a reason for hiding this comment

katybaulch left a comment

Choose a reason for hiding this comment