feature/app-159-family-page-errors-in-the-admin-when-trying-to-update #281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ys in the payload, so an error will raise if its not included
I had originally left this in because I wanted to do the tidy up of the geographies parameter separately, it seems that it causes an intermittent bug that only gets triggered when you try and update one of the basic properties. It is expecting the query to return one geo id but it does not when we have families with multiple geos per the title so it fails with : Raises sqlalchemy.orm.exc.NoResultFound if the query selects no rows. Raises sqlalchemy.orm.exc.MultipleResultsFound if multiple object identities are returned, or if multiple rows are returned for a query that returns only scalar values as opposed to full identity-mapped entities.
we are removing its use in the repository update function
cleanup will be handled in a separate ticket
allows users to access postico and other agents of the db in the dev container
annaCPR
approved these changes
Jan 16, 2025
odrakes-cpr
deleted the
fix-multiple-rows-found-when-running-update-with-multiple-geographies
branch
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix - family updates error when trying to update documents and events in the admin service
error due to multiple rows found when running update_intention for a single geo id - which fails on families with multiple geographies.
Please include:
Proposed version
Please select the option below that is most relevant from the list below. This
will be used to generate the next tag version name during auto-tagging.
Visit the Semver website to understand the
difference between
MAJOR,MINOR, andPATCHversions.Notes:
used -- e.g. Major > Minor > Patch
sure your selected option is marked
[x]with no spaces in between thebrackets and the
xType of change
Please select the option(s) below that are most relevant:
How Has This Been Tested?
Please describe the tests that you added to verify your changes.
Reviewer Checklist