-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Feature/app 183 add logging to search endpoint #287
Feature/app 183 add logging to search endpoint #287
Conversation
- our search endpoint is running pretty slow, adding some logging to see the time it takes to run the query. We suspect this is related to the joins added for multi geos.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note on logging - also wondered as a secondary step we might just add a middleware that does this?
print may get swallowed up and not come through in the logs
Updated accordingly. It adds
|
this adds a timing function to the middleware which will record response time on our requests, had to update some dependencies
- this is handled by the middle ware and makes no sense to duplicate
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great find - love the middleware!
Description
Add logging to the search endpoint, we want to not only measure the time it takes to run a query but use this metric to determine if a fix has made a viable improvement for our users.
Proposed version
Please select the option below that is most relevant from the list below. This
will be used to generate the next tag version name during auto-tagging.
Visit the Semver website to understand the
difference between
MAJOR
,MINOR
, andPATCH
versions.Notes:
used -- e.g. Major > Minor > Patch
sure your selected option is marked
[x]
with no spaces in between thebrackets and the
x
Type of change
Please select the option(s) below that are most relevant:
How Has This Been Tested?
Please describe the tests that you added to verify your changes.
Reviewer Checklist