Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: document update would error when updating language #291

Conversation

odrakes-cpr
Copy link
Contributor

@odrakes-cpr odrakes-cpr commented Feb 3, 2025

Description

  • turns out we were trying to access the language record/model to update the document relationship, we were filtering by language name field and providing it the language code

Proposed version

Please select the option below that is most relevant from the list below. This
will be used to generate the next tag version name during auto-tagging.

  • Skip auto-tagging
  • [s] Patch
  • Minor version
  • Major version

Visit the Semver website to understand the
difference between MAJOR, MINOR, and PATCH versions.

Notes:

  • If none of these options are selected, auto-tagging will fail
  • Where multiple options are selected, the most senior option ticked will be
    used -- e.g. Major > Minor > Patch
  • If you are selecting the version in the list above using the textbox, make
    sure your selected option is marked [x] with no spaces in between the
    brackets and the x

Type of change

Please select the option(s) below that are most relevant:

  • Bug fix
  • New feature
  • Breaking change
  • GitHub workflow update
  • Documentation update
  • Remove legacy code
  • Dependency update

How Has This Been Tested?

Please describe the tests that you added to verify your changes.

Reviewer Checklist

  • DB_CLIENT DEPENDENCY IS ON THE LATEST VERSION
  • The PR represents a single feature (small drive-by fixes are also ok)
  • The PR includes tests that are sufficient for the level of risk
  • The code is sufficiently commented, particularly in hard-to-understand areas
  • Any required documentation updates have been made
  • Any TODOs added are captured in future tickets
  • No FIXMEs remain

Osneil Drakes added 2 commits February 3, 2025 15:34
- turns out we were trying to access the language record/model to update
  the document relationship, we were filtering by language name field
  and providing it the language code
@odrakes-cpr odrakes-cpr requested a review from a team as a code owner February 3, 2025 15:36
Copy link

linear bot commented Feb 3, 2025

Copy link
Contributor

@jamesgorrie jamesgorrie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No tests? 😢
But fixes the bug!

@odrakes-cpr
Copy link
Contributor Author

odrakes-cpr commented Feb 4, 2025

No tests? 😢 But fixes the bug!

ahhh sorry @jamesgorrie , this was in a state of limbo - whilst i deliberated fixing it on the front end, which I have decided to do .. so closing this one

climatepolicyradar/navigator-admin-frontend#162

@odrakes-cpr
Copy link
Contributor Author

Fixing this bug on the frontend instead of making code changes in the backend to ensure consistency between the create and update endpoints.

climatepolicyradar/navigator-admin-frontend#162

@odrakes-cpr odrakes-cpr closed this Feb 4, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants