Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

NTLMv2 support for DOMAIN\UserName and username@domain.com username variations #4

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

gautamsi
Copy link

I wanted to use this package for NTLMv2 support in my repo ews-javascript-api-auth. found out that domain\username format does not work in multiple domain forest. or even multiple forest scenario. upn format does not work either.

figured that you have it hardcoded to domain/target returned from type2 message from server. With few tweaks it does work in both scenario. I have tested in cross forest scenario as well, both domain\username as well as username@domain.com works.

@s-KaiNet
Copy link

@gautamsi do you have an example, which value should I provide as target for createType3Message method in case, if I want to use upn format (user@domain)?

@s-KaiNet
Copy link

Found it :) just empty string

@jhorbulyk jhorbulyk mentioned this pull request Sep 21, 2018
@jhorbulyk jhorbulyk mentioned this pull request Sep 21, 2018
Fix bugs
no longer crashes the process when url is invalid.
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants