Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Standardize test names #366

Merged
merged 1 commit into from
Jul 17, 2016
Merged

Conversation

dpsutton
Copy link
Contributor

Before submitting a PR make sure the following things have been done:

  • The commits are consistent with our contribution guidelines
  • You've added tests to cover your change(s)
  • All tests are passing cljs tests are not passing. I can't tell if more or less are now though as @Malabarba mentioned there were some failing ones before
  • The new code is not generating reflection warnings
  • You've updated the readme (if adding/changing middleware)

Thanks!

@dpsutton dpsutton mentioned this pull request Jul 17, 2016
@dpsutton
Copy link
Contributor Author

Hmm. Clj passes on 1.7 for me whereas this says there's a failure for a future. The cljs stuff I'm unable to get to run on master or my branch, but the tests here just seem to almost time out, not error. But the tests error for me with the cljs profile.

@bbatsov bbatsov merged commit eff2d42 into clojure-emacs:master Jul 17, 2016
@bbatsov
Copy link
Member

bbatsov commented Jul 17, 2016

Guess the failures were random, as restarting the build took care of them. Thanks for working on this! 👍

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants