Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update see-alsos from the latest ClojureDocs database dump #477

Merged
merged 1 commit into from
Jan 21, 2018
Merged

Update see-alsos from the latest ClojureDocs database dump #477

merged 1 commit into from
Jan 21, 2018

Conversation

ckoparkar
Copy link
Contributor

Before submitting a PR make sure the following things have been done:

  • The commits are consistent with our contribution guidelines
  • You've added tests to cover your change(s)
  • All tests are passing
  • The new code is not generating reflection warnings
  • You've updated the readme (if adding/changing middleware)

Thanks!

@ckoparkar
Copy link
Contributor Author

ckoparkar commented Jan 20, 2018

From what I can tell, Travis is using an older version of orchard and it's not able to find as-sym at pprint.clj:40. I fixed the failures on my local machine by bumping orchard's version to 0.1.1-SNAPSHOT and re-installing. Maybe it just needs another deploy ?

@bbatsov
Copy link
Member

bbatsov commented Jan 21, 2018

Maybe it just needs another deploy ?

Yeah, I just pushed the latest version to Clojars. My bad.

Thanks for this quick response with this!

I just had one thought about this - probably we need to check whether all the functions that are related to the one we're checking for are actually bound, so on older Clojures we won't return something that doesn't exist yet. Not a big deal, but simple to implement.

@bbatsov bbatsov merged commit 3626139 into clojure-emacs:master Jan 21, 2018
@ckoparkar
Copy link
Contributor Author

No problem! Feels good to have a CIDER commit after a long long time :-)

@bbatsov
Copy link
Member

bbatsov commented Jan 22, 2018

It's nice to have you around again! And there are plenty of tasks that you can help us with. 😉

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants