add defcustom cider-use-ssh-to-infer-remote-ports #2506
Conversation
|
I don't use tramp, so I don't really care about this much. With me it's perfectly fine to just delete everything tramp-related, as it has been nothing but a pain in the ass for me. At this point I hate tramp (both because of CIDER and Projectile). :-) On the other hand a lot of people seem to be using it for some weird reason... In principle I'm fine with the suggested change. |
| (with-current-buffer (tramp-get-connection-buffer (cider--tramp-file-name vec)) | ||
| (cider-locate-running-nrepl-ports dir)))))) | ||
| (when cider-use-ssh-to-infer-remote-nrepl-ports | ||
| (let ((vec (vector "sshx" nil host "" nil)) |
There was a problem hiding this comment.
I wonder if we shouldn't move the remote logic to a separate function.
There was a problem hiding this comment.
I tried that, but it didn't seem like a big win, especially since this function is already entangled with an ssh-hosts arg.
cider.el
Outdated
| @@ -1327,6 +1327,11 @@ Tramp version starting 26.1 is using a `cl-defstruct' rather than vanilla VEC." | |||
| (make-tramp-file-name :method (elt vec 0) | |||
| :host (elt vec 2))))) | |||
|
|
|||
| (defcustom cider-use-ssh-to-infer-remote-nrepl-ports t | |||
There was a problem hiding this comment.
Probably we can shorten this simply to cider-infer-remote-nrepl-ports.
The defcustom should be moved to the top of the file and annotated accordingly.
Yeah, same with me. My workflow is that I always edit files locally. When I connect to a remote repl, it's always a direct connection and I use git to sync files, rather than editing files remotely with tramp. But I'm sympathetic to the workflow of editing files remotely with tramp. Another strategy would be to have a master var, |
|
It's a good suggestion, but ideally the |
OK, i'll clean this up and add docs for it. |
aiba
force-pushed
the
cider-use-ssh-to-infer-remote-ports
branch
from
42d4b50 to
fd2855b
Compare
|
OK, I think this PR is ready for another look. I considered adding documentation to |
|
I think it might actually be nice to add some section on connecting over ssh, but that's not that big of a deal. |
CHANGELOG.md
Outdated
| @@ -25,6 +25,7 @@ | |||
| ### Changes | |||
|
|
|||
| * [#2482](https://github.com/clojure-emacs/cider/issues/2482): Don't bind nREPL server started by `cider-jack-in` to `::` (use `localhost` instead). | |||
| * [#1544](https://github.com/clojure-emacs/cider/issues/1544): Add a new defcustom `cider-infer-remote-nrepl-ports` to control whether we use tramp/ssh to infer remote ports. Now defaulting to `nil` (previously it alwasy tried to infer). | |||
cider.el
Outdated
| (defcustom cider-infer-remote-nrepl-ports nil | ||
| "When true, cider will use ssh to try to infer nREPL ports on remote hosts." | ||
| :type 'boolean | ||
| :safe #'booleanp) |
There was a problem hiding this comment.
You should also add a :package-version property (0.19.0).
|
Btw, it seems to me that the two ssh options should probably be mentioned in http://www.cider.mx/en/latest/up_and_running/, as this makes more sense than the generic configuration section. |
I can take a stab at docs for this. To me it makes sense to have a section somewhere (perhaps up-and-running, or perhaps a new page) called "Connecting over SSH". And I'm not sure I understand all of cider's behavior wrt ssh connections well enough to write this section, but I'll give it a try. |
aiba
force-pushed
the
cider-use-ssh-to-infer-remote-ports
branch
from
fd2855b to
fe81bd7
Compare
|
I think this is ready for another look. |
This is just an idea to address #1544. If the cider maintainers want it, I can update this PR to also include documentation of the new defcustom.